Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12_6_X] Fix PostDQMOffline* sequences in cmsDriver.py #40294

Merged
merged 1 commit into from
Dec 14, 2022
Merged

[12_6_X] Fix PostDQMOffline* sequences in cmsDriver.py #40294

merged 1 commit into from
Dec 14, 2022

Conversation

elusian
Copy link

@elusian elusian commented Dec 12, 2022

PR description:

When adding a DQM sequence to the command line options (e.g. DQM:@miniAODDQM), cmsDriver.py is supposed to add the relative PostDQMOffline sequence as selected in autoDQM.py.
However, due to this commit in CMSSW_12_6_0_pre3, this does not happen anymore.

After the commit sequenceList and postSequenceList are the same object at the same address and filling sequenceList inhibits the fill of postSequenceList (since expandMapping sees no "@" in the array). Since the sequences are the same, no dqmofflineOnPAT_step is produced in the output.

This PR splits the assigment into two lines, which makes sequenceList and postSequenceList distinct again.

PR validation:

Created a simple config file passing DQM:@miniAODDQM to cmsDriver.py, requested PostDQMOffline* sequences are back in the process.schedule as they were in CMSSW_12_6_0_pre2

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #40293 for CMSSW 12_6_X

@cmsbuild cmsbuild added this to the CMSSW_12_6_X milestone Dec 12, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 12, 2022 •
edited
Loading

A new Pull Request was created by @elusian for CMSSW_12_6_X.

It involves the following packages:

  • Configuration/Applications (operations)

@cmsbuild, @perrotta, @rappoccio, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @missirol, @fabiocos, @Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Dec 12, 2022

backport of #40293

@mmusich
Copy link
Contributor

mmusich commented Dec 12, 2022

type bug-fix

@mmusich
Copy link
Contributor

mmusich commented Dec 12, 2022 •
edited
Loading

urgent

  • should enter 12_6_0

@mmusich
Copy link
Contributor

mmusich commented Dec 12, 2022

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d73b95/29575/summary.html
COMMIT: c0aa459
CMSSW: CMSSW_12_6_X_2022-12-12-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40294/29575/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 38 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3416898
  • DQMHistoTests: Total failures: 56
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3416820
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 76941.71699999996 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 640.710 KiB JetMET/PFCandidates
  • DQMHistoSizes: changed ( 10024.0,... ): 448.898 KiB ParticleFlow/slimmedJetValidation
  • DQMHistoSizes: changed ( 10024.0,... ): 263.359 KiB ParticleFlow/slimmedElectronValidation
  • DQMHistoSizes: changed ( 10024.0,... ): 261.354 KiB ParticleFlow/slimmedMuonValidation
  • DQMHistoSizes: changed ( 10024.0,... ): 239.348 KiB ParticleFlow/slimmedMETValidation
  • DQMHistoSizes: changed ( 10024.0,... ): 239.010 KiB Physics/Top
  • DQMHistoSizes: changed ( 10024.0,... ): 236.857 KiB JetMET/Jet
  • DQMHistoSizes: changed ( 10024.0,... ): 198.366 KiB JetMET/MET
  • DQMHistoSizes: changed ( 10024.0,... ): 37.338 KiB ParticleFlow/PFJetResValidation
  • DQMHistoSizes: changed ( 10024.0,... ): 24.309 KiB Tracking/PackedCandidate
  • DQMHistoSizes: changed ( 13234.0 ): ...
  • Checked 206 log files, 158 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 548a19d into cms-sw:CMSSW_12_6_X Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok bug-fix fully-signed operations-approved orp-approved tests-approved urgent
Projects
None yet
Milestone
CMSSW_12_6_X
Development

Successfully merging this pull request may close these issues.
4 participants
@elusian @cmsbuild @mmusich @perrotta